uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "KuiLIU (JIRA)" <...@uima.apache.org>
Subject [jira] [Commented] (UIMA-5769) Inconsistent method name
Date Sun, 22 Apr 2018 08:10:00 GMT

    [ https://issues.apache.org/jira/browse/UIMA-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447139#comment-16447139
] 

KuiLIU commented on UIMA-5769:
------------------------------

uima-uimaj/uimaj-ep-cas-editor/src/main/java/org/apache/uima/caseditor/editor/FeatureStructureSelection.java

https://github.com/apache/uima-uimaj/pull/2

> Inconsistent method name
> ------------------------
>
>                 Key: UIMA-5769
>                 URL: https://issues.apache.org/jira/browse/UIMA-5769
>             Project: UIMA
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named "toList" that seems like to convert one object to a list,
but the method just returns a list of FeatureStructure objects, so that the method name "getList"
should be more clear than "toList".
> {code:java}
>  /**
>    * Retrieves a list of {@link FeatureStructure} objects.
>    *
>    * @return all selected {@link FeatureStructure} objects
>    */
>   public List<FeatureStructure> toList() {
>     return mFeatureStructures;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message