uima-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [uima-uimaj] reckart commented on pull request #56: [UIMA-6267] UIMA SDK Eclipse Plugins fail to build after Eclipse 2020-09 release
Date Wed, 30 Sep 2020 21:12:41 GMT

reckart commented on pull request #56:
URL: https://github.com/apache/uima-uimaj/pull/56#issuecomment-701649021


   > Is there any implication of breakage for people still running older levels of Eclipse?

   
   Hard to tell - that is why I am asking for a review ;) Comparing the Manifests files generated
before and after the excludes, I don't see any differences for the most part. In the `uimaj-ep-configurator`,
I can see that one package less is imported after the exclusions (`org.eclipse.jface.util`),
but the rest all seem to be the same save for timestamps.
   
   With the ranges in the dependencies, it basically means that Maven downloads and compiles
against the respectively most recent versions of the libraries it can find. Assuming the ranges
are trustworthy, it probably shouldn't impact the range of supported Eclipse versions. But
theoretically, if there was an incompatible change in some dependency, it could be that a
class compiled against a recent version doesn't run against and older version (even if a class
compiled against an older version might run against the new version).
   
   If there is a quick and easy way of validating/testing this, I can try - but I don't really
want to go back and download all versions of Eclipse since the dawn of time to test against
them...
   
   So I'll merge it and if anybody later hits a wall, we can still update the requirements.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message