velocity-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Gaspar" <paulo.gas...@krankikom.de>
Subject RE: DBResourceLoader checked in
Date Fri, 23 Feb 2001 06:21:25 GMT
> -----Original Message-----
> From: gmj@mta4.srv.hcvlny.cv.net [mailto:gmj@mta4.srv.hcvlny.cv.net]On
> Behalf Of Geir Magnusson Jr.
> 
> The DBResourceLoader is now checked in to o.a.v.runtime.resource.loader.
> ....

Hi Geir,


David had sugested changing the name of that to DataSourceResourceLoader.


Bye,
Paulo

> -----Original Message-----
> From: David Kinnvall [mailto:david.kinnvall@alertir.com]
> Sent: Monday, February 19, 2001 23:07
> To: velocity-dev@jakarta.apache.org
> Subject: RE: DBResourceLoader proposal.
> 
> 
> At 22:55 2001-02-19, Paulo wrote:
> >Hi David,
> 
> Hi Paulo!
> 
> 
> >At a first glance:
> >  - DBResourceLoader.isSourceModified() has too much code in common
> >    with DBResourceLoader.getLastModified();
> >  - There is some more code repeated.
> >
> >Without (almost) changing the functionality, what about this
> >implementation (just the DBResourceLoader class)?
> >
> >
> >Paulo
> 
> [new implementation snipped]
> 
> Yup. Looks fine to me. It was a first iteration anyway. :-)
> 
> I read your previous post regarding placement of this loader
> and the need for other methods of getting resources from
> databases. How about resolving some of the issues by renaming
> this particular loader to DataSourceResourceLoader instead of
> DBResourceLoader? That would emphasize the fact that it is
> DataSource specific and leave the field open for other
> database-related loaders while eliminating naming conflicts?
> 
> /David
> 



Mime
View raw message