velocity-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shinobu Kawai <shinobu.ka...@gmail.com>
Subject Re: Example of AbstractPagerTool
Date Thu, 04 Nov 2004 21:26:00 GMT
Hi Manish,

> I am not 100% sure, but I think this part of the code is te reason why
> slip-size of 20 returns only 19 items in the list.
> Me thinks it's incorrect, can someone explain the reason behined this?
> 
> /* don't include current page in slip size calcs */
> int adjSlipSize = slipSize - 1;
I think it's rather here:
    for (int i=slipStart; i < slipEnd; i++)
Since we want to include the slipEnd, it should read
    for (int i=slipStart; i <= slipEnd; i++)

Anyways, this looks like a bug.  Could you file an issue?  (And
perhaps a patch?  B))
    http://issues.apache.org/bugzilla/enter_bug.cgi?product=Velocity

Best regards,
-- Shinobu Kawai

-- 
Shinobu Kawai <shinobu.kawai@gmail.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org


Mime
View raw message