velocity-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Will Glass-Husain" <wgl...@forio.com>
Subject Re: Loaders and Hashtable+Vector legacy use?
Date Tue, 05 Jul 2005 13:59:59 GMT
At first glance this looks good.  I'll commit this in the next day or two.

What are the changes to the build file?  Did you mean to include those?  (no 
need to reattach the diff, I'll just ignore them).

WILL


----- Original Message ----- 
From: "mailmur" <mailmur@yahoo.com>
To: "Velocity Users List" <velocity-user@jakarta.apache.org>
Sent: Monday, July 04, 2005 11:05 PM
Subject: Re: Loaders and Hashtable+Vector legacy use?


> Well, that was easy after all. I went to the root of
> velocity SVN dump folder and run "svn diff >
> patch.txt". I used svn-win32-1.2.0 client package.
>
> About commit:
> I believe I don't have a commit access so no need to
> worry about modified files in my working copy folder.
> If you guys accept this patch I probably get changes
> later in a update command.
>
> --- Will Glass-Husain <wglass@forio.com> wrote:
>
>> Hi Mailmur,
>>
>> Thanks again for doing this.  Do you have the
>> command line "svn" client
>> installed?  You should be able to cd to the root
>> Velocity directory, then
>> type at the command line
>>
>> svn diff > patch.txt
>>
>> to run a diff and save it in the file "patch.txt".
>> It does a comparison
>> between all files (recursive) in that directory and
>> the copy in source
>> control.  This assumes you've downloaded the source
>> with svn in the first
>> place.
>>
>> (Other diff programs will require two copies.  But
>> the svn with the diff
>> action only requires the modified copy on your
>> computer).
>>
>> WILL
>>
>> ----- Original Message ----- 
>> From: "mailmur" <mailmur@yahoo.com>
>> To: "Velocity Users List"
>> <velocity-user@jakarta.apache.org>
>> Sent: Monday, July 04, 2005 10:02 PM
>> Subject: Re: Loaders and Hashtable+Vector legacy
>> use?
>>
>>
>> > The following changes where made
>> > ================================
>> > * added src/java/META-INF/MANIFEST.MF file
>> > _all_ java packages should have a _meaninfull_
>> > manifest file. This is a sort of win exefile's
>> > VersionInfo tabsheet and is really a good quality
>> of
>> > service.
>> >
>> > * modified build/build.xml file
>> > create jars with given manifest.mf file
>> > - added src/java/meta-inf to prepare copyfile set
>> > - added compile-copy-metainf target and use it in
>> > various jarXXX targets
>> >
>> > * modified resourceloaders
>> >
>> runtime/resource/loader/ClasspathResourceLoader.java
>> > runtime/resource/loader/FileResourceLoader.java
>> > runtime/resource/loader/JarResourceLoader.java
>> > - removed unnecessary synchronized blocks to slow
>> > things down
>> > - converted legacy Vector and hashtable classes to
>> > ArrayList and HashMap, this is another performance
>> > optimization. No need to use legacy classes
>> anymore.
>> > They are _implicitly_ synchronized so slow this
>> down
>> > if we don't need any synchronization.
>> >
>> > Note: many part of internal velocity engine still
>> use
>> > legacy classes, but we have to live with it at the
>> > moment.
>> >
>> > - - -
>> > I could not make a diff files, probably am missing
>> a
>> > diff tool or am just a n000b. I tried to google
>> but
>> > could not find anything I should install.
>> >
>> > Environment: Win2k,EclipseIDE,RapidSVN client
>> >
>> > Until then, I have posted a link to my webpage and
>> a
>> > zipfile where is all files modified.
>> >
>>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=35558
>> >
>> > svn diff > patch.txt is not clearly a full
>> command.
>> > RapidSVN menu has a diff option, I tried
>> preferences
>> > to point it to "svn.exe diff" tool but did not
>> work.
>> > Then I have VisDiff.exe in WinCVS client, but it
>> just
>> > displayed a graphical comparision.
>> >
>> > Oh why always its so complicated to make even
>> simple
>> > point-and-click tasks :-(
>> >
>> > thx
>> > --- Will Glass-Husain <wglass@forio.com> wrote:
>> >> Sounds good so far.  I use the "svn" command line
>> >> client, the "TortoiseSVN" client for use in
>> Windows,
>> > and the Subclipse integrated with Eclipse.
>> >
>> >> (4) Make a diff file in "unified" format with
>> this
>> >> command: svn diff > patch.txt
>> >
>> > __________________________________________________
>> > Do You Yahoo!?
>> > Tired of spam?  Yahoo! Mail has the best spam
>> protection around
>> > http://mail.yahoo.com
>> >
>> >
>>
> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail:
>> velocity-user-unsubscribe@jakarta.apache.org
>> > For additional commands, e-mail:
>> velocity-user-help@jakarta.apache.org
>> >
>>
>>
>>
> ---------------------------------------------------------------------
>> To unsubscribe, e-mail:
>> velocity-user-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail:
>> velocity-user-help@jakarta.apache.org
>>
>>
>
>
>
>
> ____________________________________________________
> Yahoo! Sports
> Rekindle the Rivalries. Sign up for Fantasy Football
> http://football.fantasysports.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: velocity-user-help@jakarta.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-user-help@jakarta.apache.org


Mime
View raw message