velocity-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: [tools] LinkTool.addAllParameters is not behaving as before [fixed]
Date Wed, 27 Jul 2011 22:27:18 GMT
Fixed in 2.0.x branch.

On 7/27/2011 4:53 PM, Christopher Schultz wrote:
> All,
> 
> On 7/27/2011 4:06 PM, Christopher Schultz wrote:
>> I do see /a/ bug in addAllParameters, but it doesn't account for the
>> problem I'm seeing.
> 
> Okay, I was wrong, the ignores list *is* being updated by addQueryData
> (indirectly through view.tools.LinkTool.setParam).
> 
> What I'm seeing is that the ignores list is bleeding-through from one
> instance to another (or, rather, the child is affecting the parent).
> 
> I believe the problem is that the ignores list /reference/ is cloned in
> generic.LinkTool.duplicate(boolean) and the list itself needs to be
> cloned. I believe view.tools.LinkTool needs to override
> duplicate(boolean) and clone the ignores list if the parameter is true.
> 
> I think this will fix this behavior, which of course I will be moving
> away from ASAP :) Good to get things working for others to preserve
> backward-compatibility, though.
> 
> -chris
> 


Mime
View raw message