whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastian Bazley <s...@apache.org>
Subject [whimsy.git] [1/1] Commit a95710c: First loop must be over ASF committers
Date Sat, 23 Jan 2016 16:57:33 GMT
Commit a95710c492b08a9cfe3e9679c43096f8f2108ecb:
    First loop must be over ASF committers


Branch: refs/heads/master
Author: Sebb <sebb@apache.org>
Committer: Sebb <sebb@apache.org>
Pusher: sebb <sebb@apache.org>

------------------------------------------------------------
www/roster/public_ldap_committers.rb                         | +++++++ ----
------------------------------------------------------------
11 changes: 7 additions, 4 deletions.
------------------------------------------------------------


diff --git a/www/roster/public_ldap_committers.rb b/www/roster/public_ldap_committers.rb
index c278879..c75db46 100644
--- a/www/roster/public_ldap_committers.rb
+++ b/www/roster/public_ldap_committers.rb
@@ -30,18 +30,20 @@
 ldap = ASF.init_ldap
 exit 1 unless ldap
 
-# gather committer info
+# normal members of the AS
 ids = {}
-# banned or deceased or emeritus or ...
+# still a committer, but banned or deceased or emeritus or ...
 ban = {}
 # people entries that are not committers (and not in nologin)
 non = {}
 # people entries that are not committers (in nologin)
 nonb = {}
 
+comms = ASF.committers
 peeps = ASF::Person.preload(['cn', 'loginShell']) # for performance
 
-peeps.sort_by {|a| a.id}.each do |entry|
+# For each ASF committer group member, check if they can login:
+comms.sort_by {|a| a.id}.each do |entry|
     if entry.banned?
         ban[entry.id] = entry.public_name 
     else
@@ -49,8 +51,9 @@
     end
 end
 
+# Now see if there are any left-over people
 peeps.sort_by {|a| a.name}.each do |e|
-  unless ASF.committers.include? e
+  unless comms.include? e
      if e.banned?
          nonb[e.name] = e.public_name
      else

Mime
View raw message