whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: handle partial (incremental) completion
Date Wed, 17 Aug 2016 23:10:06 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  66f878a   handle partial (incremental) completion
66f878a is described below

commit 66f878a0aab3fc31f1e418c38ef826b6a625a418
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Wed Aug 17 19:09:45 2016 -0400

    handle partial (incremental) completion
---
 www/board/agenda/views/pages/adjournment.js.rb | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/www/board/agenda/views/pages/adjournment.js.rb b/www/board/agenda/views/pages/adjournment.js.rb
index b3b9103..c7a00c1 100644
--- a/www/board/agenda/views/pages/adjournment.js.rb
+++ b/www/board/agenda/views/pages/adjournment.js.rb
@@ -55,35 +55,35 @@ class Adjournment < React
         completed = Todos.minutes.todos
         if 
           completed and completed.keys().length > 0 and (
-          not completed.added.empty? or 
-          not completed.removed.empty? or
-          not completed.established.empty? or 
-          not completed.feedback_sent.empty?)
+          (completed.added and not completed.added.empty?) or 
+          (completed.removed and not completed.removed.empty?) or
+          (completed.established and not completed.established.empty?) or 
+          (completed.feedback_sent and not completed.feedback_sent.empty?))
         then
           _h3 'Completed actions'
 
-          unless completed.added.empty?
+          if completed.added and not completed.added.empty?
             _p 'Added to PMC chairs'
             _ul completed.added do |id|
               _li {_a id, href: "../../../roster/committer/#{id}"}
             end
           end
 
-          unless completed.removed.empty?
+          if completed.removed and not completed.removed.empty?
             _p 'Removed from PMC chairs'
             _ul completed.removed do |id|
               _li {_a id, href: "../../../roster/committer/#{id}"}
             end
           end
 
-          unless completed.established.empty?
+          if completed.established and not completed.established.empty?
             _p 'Established PMCs'
             _ul completed.established do |pmc|
               _li {_a pmc, href: "../../../roster/committee/#{pmc}"}
             end
           end
 
-          unless completed.feedback_sent.empty?
+          if completed.feedback_sent and not completed.feedback_sent.empty?
             _p 'Sent feedback'
             _ul completed.feedback_sent do |pmc|
               _li {_Link text: pmc, href: pmc.gsub(/\s+/, '-')} 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message