whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: remove buttons if person changed
Date Mon, 23 Jan 2017 17:52:44 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/whimsy.git

The following commit(s) were added to refs/heads/master by this push:
       new  00d74fc   remove buttons if person changed
00d74fc is described below

commit 00d74fc890730b8ec6b15a58ed5d630b921b1382
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Mon Jan 23 12:52:26 2017 -0500

    remove buttons if person changed
---
 www/roster/views/pmc/committers.js.rb | 5 +----
 www/roster/views/pmc/pmc.js.rb        | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/www/roster/views/pmc/committers.js.rb b/www/roster/views/pmc/committers.js.rb
index 0a14cbd..7dc1698 100644
--- a/www/roster/views/pmc/committers.js.rb
+++ b/www/roster/views/pmc/committers.js.rb
@@ -133,10 +133,7 @@ class PMCCommitter < React
 
   # automatically open pending entries
   def componentWillReceiveProps(newprops)
-    if self.committee and newprops.committee.id != self.committee.id
-      @state = :closed 
-    end
-
+    @state = :closed if newprops.person.id != self.person.id
     @state = :open if @@person.date == 'pending'
   end
 
diff --git a/www/roster/views/pmc/pmc.js.rb b/www/roster/views/pmc/pmc.js.rb
index 1213423..dff4208 100644
--- a/www/roster/views/pmc/pmc.js.rb
+++ b/www/roster/views/pmc/pmc.js.rb
@@ -191,7 +191,7 @@ class PMCMember < React
 
   # automatically open pending entries
   def componentWillReceiveProps(newprops)
-    @state = :closed if @committee and newprops.committee.id != @committee.id
+    @state = :closed if newprops.person.id != self.props.person.id
     @state = :open if @@person.date == 'pending'
   end
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message