whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From curc...@apache.org
Subject [whimsy] branch master updated: Enable non-valid ids to passthru
Date Sun, 11 Jun 2017 19:34:15 GMT
This is an automated email from the ASF dual-hosted git repository.

curcuru pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new a56e646  Enable non-valid ids to passthru
a56e646 is described below

commit a56e646ddc4f3caa3d077201b5560ea046848e5b
Author: Shane Curcuru <asf@shanecurcuru.org>
AuthorDate: Sun Jun 11 15:34:11 2017 -0400

    Enable non-valid ids to passthru
    
    Credit @gstein, @rubys
---
 www/foundation/orgchart.cgi | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/www/foundation/orgchart.cgi b/www/foundation/orgchart.cgi
index ae887d0..b72724b 100755
--- a/www/foundation/orgchart.cgi
+++ b/www/foundation/orgchart.cgi
@@ -42,7 +42,7 @@ def emit_orgchart(org: {})
             end
             _td do
               id = value['info']['id'] || value['info']['chair']
-              _ ASF::Person.find(id).public_name
+              _ ASF::Person.find(id).public_name || id
             end
             _td do
               web = value['info']['website']
@@ -58,8 +58,9 @@ end
 # Output one role's duties and data
 def emit_role(role: {}, oversees: {}, desc: {})
   id = role['info']['id'] || role['info']['chair']
+  idnam = ASF::Person.find(id).public_name || id
   _whimsy_panel_table(
-  title: "#{role['info']['role']} - #{ASF::Person.find(id).public_name}",
+  title: "#{role['info']['role']} - #{idnam}",
   ) do
     _table.table.table_striped do
       _tbody do
@@ -76,7 +77,7 @@ def emit_role(role: {}, oversees: {}, desc: {})
             end
             if %w(id chair).include? key
               _td do
-                _ ASF::Person.find(id).public_name
+                _ idnam
               end
             elsif %w(reports-to).include? key
               _td! do

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message