whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: expand experiment: pmc=>project
Date Thu, 22 Jun 2017 18:59:11 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 45d62fb  expand experiment: pmc=>project
45d62fb is described below

commit 45d62fb0ff210b21d4754222cdad0aa8b406e28b
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Thu Jun 22 14:58:11 2017 -0400

    expand experiment: pmc=>project
    
    Ultimately, GUINEAPIG and guinea_pig are markers for code that need to be
    cleaned up when the experiment completes.
---
 www/roster/models/committee.rb             | 1 +
 www/roster/views/actions/committee.json.rb | 2 +-
 www/roster/views/pmc/main.js.rb            | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/www/roster/models/committee.rb b/www/roster/models/committee.rb
index 6d3312e..e3c1a1f 100644
--- a/www/roster/models/committee.rb
+++ b/www/roster/models/committee.rb
@@ -47,6 +47,7 @@ class Committee
       modtime: modtime,
       project_info: info,
       image: image,
+      guinea_pig: ASF::Committee::GUINEAPIGS.include?(id),
     }
 
     response
diff --git a/www/roster/views/actions/committee.json.rb b/www/roster/views/actions/committee.json.rb
index a6d2df6..ce1075d 100644
--- a/www/roster/views/actions/committee.json.rb
+++ b/www/roster/views/actions/committee.json.rb
@@ -94,7 +94,7 @@ if env.password
   end
 
   details = people.map {|person| person.dn}
-  if pmc.id == 'incubator'
+  if ASF::Committee::GUINEAPIGS.include? pmc.id
     details << "#{pmc.dn};attr=owner" if @targets.include? 'pmc'
     details << "#{pmc.dn};attr=member" if group
   else
diff --git a/www/roster/views/pmc/main.js.rb b/www/roster/views/pmc/main.js.rb
index acd4483..d7c0992 100644
--- a/www/roster/views/pmc/main.js.rb
+++ b/www/roster/views/pmc/main.js.rb
@@ -8,7 +8,7 @@ class PMC < React
   end
 
   def render
-    if @committee.id == 'incubator'
+    if @committee.guinea_pig
       auth = (@@auth.secretary or @@auth.root or
         @committee.ldap.keys().include? @@auth.id)
     else

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message