This is an automated email from the ASF dual-hosted git repository.
clr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 2e9bf6c project/icla Update comment text for discuss and vote
2e9bf6c is described below
commit 2e9bf6c8e71c275f6c62c14bbed75c4b447a272f
Author: Craig L Russell <craig.russell@oracle.com>
AuthorDate: Tue Jan 2 15:20:17 2018 -0800
project/icla Update comment text for discuss and vote
---
www/project/icla/views/pages/invite.js.rb | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/www/project/icla/views/pages/invite.js.rb b/www/project/icla/views/pages/invite.js.rb
index 9c6434d..b5d55d8 100644
--- a/www/project/icla/views/pages/invite.js.rb
+++ b/www/project/icla/views/pages/invite.js.rb
@@ -16,6 +16,7 @@ class Invite < Vue
@subjectPhase = ''
@previewMessage = 'Preview'
@pmcOrPpmc = ''
+ @phasePrefix = ''
# initialize conditional text
@showPMCVoteLink = false;
@@ -174,9 +175,10 @@ class Invite < Vue
_input type: :radio, name: :role, value: :committer,
onClick: -> {@role = :committer;
@subject = @subjectPhase + ' Invite ' + @iclaname +
- ' to become committer for ' + @pmc
+ ' to become a committer for ' + @pmc
}
- _span :' invite to become a committer'
+ _span @phasePrefix +
+ ' invite to become a committer'
end
_br
_label do
@@ -185,7 +187,8 @@ class Invite < Vue
@subject = @subjectPhase + ' Invite ' + @iclaname +
' to become committer and ' + @pmcOrPPMC + ' member for ' + @pmc
}
- _span ' invite to become a committer and ' + @pmcOrPPMC + ' member'
+ _span @phasePrefix +
+ ' invite to become a committer and ' + @pmcOrPPMC + ' member'
end
if @showDiscussFrame
_br
@@ -195,7 +198,8 @@ class Invite < Vue
@subject = @subjectPhase + ' Invite ' + @iclaname +
' to submit an ICLA for ' + @pmc
}
- _span ' invite to submit an ICLA'
+ _span @phasePrefix +
+ ' invite to submit an ICLA'
end
end
_p
@@ -204,14 +208,14 @@ class Invite < Vue
if @showDiscussFrame
_div 'Subject: ' + @subject
_textarea.form_control rows: 4,
- placeholder: 'Please discuss this candidate',
+ placeholder: 'This is a discussion for the candidate',
name: 'discussBody', value: @discussBody,
onChange: self.setDiscussBody
end
if @showVoteFrame
_div 'Subject: ' + @subject
_textarea.form_control rows: 4,
- placeholder: 'Please discuss this candidate',
+ placeholder: 'This is a vote for the candidate. Here is my +1',
name: 'voteBody', value: @voteBody,
onChange: self.setVoteBody
end
@@ -303,6 +307,7 @@ class Invite < Vue
@subject = ''
@subjectPhase = '[DISCUSS]'
@previewMessage = 'Preview Discussion'
+ @phasePrefix = ' Start the discussion to'
@showDiscussFrame = true;
@showRoleFrame = true;
@showVoteFrame = false;
@@ -325,6 +330,7 @@ class Invite < Vue
@subject = ''
@subjectPhase = '[VOTE]'
@previewMessage = 'Preview Vote'
+ @phasePrefix = ' Start the vote to'
@showVoteFrame = true;
@showRoleFrame = true;
@showDiscussFrame = false;
--
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].
|