whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Don't re-use id variable
Date Fri, 05 Jan 2018 00:41:35 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new c597351  Don't re-use id variable
c597351 is described below

commit c59735103aeaa506d77771cd5ddd920c78a86183
Author: Sebb <sebb@apache.org>
AuthorDate: Fri Jan 5 00:41:23 2018 +0000

    Don't re-use id variable
---
 www/roster/models/committer.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/roster/models/committer.rb b/www/roster/models/committer.rb
index 34371a0..34f7544 100644
--- a/www/roster/models/committer.rb
+++ b/www/roster/models/committer.rb
@@ -165,8 +165,8 @@ class Committer
       ASF::MLIST.digests(person.all_mail, response)
       # Check for missing private@ subscriptions
       response[:privateNosub] = []
-      response[:committees].each do |id|
-        pmc = ASF::Committee.find(id)
+      response[:committees].each do |cttee|
+        pmc = ASF::Committee.find(cttee)
         pmail = "private@#{pmc.mail_list}.apache.org" rescue ''
         subbed = false
         response[:subscriptions].each do |sub|
@@ -174,7 +174,7 @@ class Committer
             subbed = true
           end
         end
-        response[:privateNosub] << id unless subbed
+        response[:privateNosub] << cttee unless subbed
       end
     end
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message