whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Net::HTTP.get does not raise errors
Date Sat, 20 Jan 2018 13:30:27 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 38c47ad  Net::HTTP.get does not raise errors
38c47ad is described below

commit 38c47ade4967b79d9c34625b0fb69d2fcd0b70e9
Author: Sebb <sebb@apache.org>
AuthorDate: Sat Jan 20 13:30:14 2018 +0000

    Net::HTTP.get does not raise errors
---
 lib/whimsy/asf/podling.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/whimsy/asf/podling.rb b/lib/whimsy/asf/podling.rb
index 3669294..5870897 100644
--- a/lib/whimsy/asf/podling.rb
+++ b/lib/whimsy/asf/podling.rb
@@ -355,7 +355,9 @@ module ASF
             'maxResults=1000&' +
             'jql=project=PODLINGNAMESEARCH&fields=summary,resolution,customfield_12310520'
         begin
-          File.write cache, Net::HTTP.get(URI(query))
+          res = Net::HTTP.get_response(URI(query))
+          res.value() # Raises error if not OK
+          File.write cache, res.body
         rescue => e
           Wunderbar.warn "ASF::Podling.namesearch: " + e.message
         end
@@ -382,6 +384,7 @@ module ASF
         [name, {issue: issue['key'], resolution: resolution}]
       end
 
+      Wunderbar.warn "ASF::Podling.namesearch: " + 'return OK'
       issues.compact.sort_by(&:first).to_h
     end
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <commits@whimsical.apache.org>'].

Mime
View raw message