whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From curc...@apache.org
Subject [whimsy] branch master updated: Fix WHIMSY-189
Date Mon, 02 Apr 2018 17:46:19 GMT
This is an automated email from the ASF dual-hosted git repository.

curcuru pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new abf308e  Fix WHIMSY-189
abf308e is described below

commit abf308e4bb20a641ac009a19b9b8c95c282b3bfa
Author: Shane Curcuru <asf@shanecurcuru.org>
AuthorDate: Mon Apr 2 13:46:13 2018 -0400

    Fix WHIMSY-189
    
    Note: changes behavior subtly when @quick=false; all people are
    represented, but some will have ids and _Unfound_Wont
---
 lib/whimsy/asf/agenda/front.rb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/whimsy/asf/agenda/front.rb b/lib/whimsy/asf/agenda/front.rb
index 434c88d..3b2e8ff 100644
--- a/lib/whimsy/asf/agenda/front.rb
+++ b/lib/whimsy/asf/agenda/front.rb
@@ -39,10 +39,8 @@ class ASF::Board::Agenda
               attending: !absent.include?(name)
             }
           else
-
             # look up name
             search = ASF::Person.list("cn=#{name}")
-
             # if found, save results in the attributes
             if search.length == 1
               person = search.first
@@ -54,6 +52,14 @@ class ASF::Board::Agenda
                 member: person.asf_member?,
                 attending: !absent.include?(name)
               }
+            else
+              # If not found, fallback to @quick behavior; WHIMSY-189
+              attr['people']['_' + name.gsub(/\W/, '_')] = {
+                name: name,
+                sortName: sort_name,
+                role: role,
+                attending: !absent.include?(name)
+              }
             end
           end
         end

-- 
To stop receiving notification emails like this one, please contact
curcuru@apache.org.

Mime
View raw message