whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: ASF::Committee.list no longer used
Date Wed, 13 Feb 2019 20:04:26 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new bd52239  ASF::Committee.list no longer used
bd52239 is described below

commit bd522398f6b8e8fca7dabdf7a56dc2027a25df94
Author: Sebb <sebb@apache.org>
AuthorDate: Wed Feb 13 20:04:18 2019 +0000

    ASF::Committee.list no longer used
---
 lib/whimsy/asf/ldap.rb | 10 +---------
 www/members/watch.cgi  |  3 ---
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index b0c0aa1..f4e61ad 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1238,17 +1238,9 @@ module ASF
 
   class Committee < Base
     # TODO what to do about this? Change to ou=project or drop?
-    # It's used by the methods: self.list, self.preload, member[id]s
+    # It's used by the methods: self.preload, member[id]s
     @base = 'ou=pmc,ou=committees,ou=groups,dc=apache,dc=org'
 
-    # return a list of committees, from LDAP.
-    # TODO this stopped returning all PMCs when guinea pigs were introduced
-    # Should it be dropped, or made to return the list of PMCs ?
-    # No longer used
-    def self.list(filter='cn=*')
-      ASF.search_one(base, filter, 'cn').flatten.map {|cn| Committee.find(cn)}
-    end
-
     # fetch <tt>dn</tt>, <tt>member</tt>, <tt>modifyTimestamp</tt>,
and
     # <tt>createTimestamp</tt> for all committees in LDAP.
     # TODO - delete? Not sure it's used anymore
diff --git a/www/members/watch.cgi b/www/members/watch.cgi
index 1079cb4..ecb59cb 100755
--- a/www/members/watch.cgi
+++ b/www/members/watch.cgi
@@ -101,9 +101,6 @@ _html do
     list = {} # Avoid lint errors of shadowing
     if request =~ /multiple/
       _h2_ 'Active In Multiple Committees'
-#      list = ASF::Committee.list.map {|committee| committee.members}.
-#        reduce(&:+).group_by {|person| person}.
-#        delete_if {|person,list| list.length<3}.keys
       # Use actual PMCs rather than LDAP derived
       list = ASF::Committee.pmcs.map {|pmc| pmc.roster.keys}.
         reduce(&:+).group_by {|uid| uid}.


Mime
View raw message