whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Broken: only returns canonical mails
Date Wed, 06 Mar 2019 17:25:32 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 5d10972  Broken: only returns canonical mails
5d10972 is described below

commit 5d1097288a8efca323afcf864a4871756ef6eba0
Author: Sebb <sebb@apache.org>
AuthorDate: Wed Mar 6 17:25:31 2019 +0000

    Broken: only returns canonical mails
---
 lib/whimsy/asf/mlist.rb | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/whimsy/asf/mlist.rb b/lib/whimsy/asf/mlist.rb
index 358417e..d0af0da 100644
--- a/lib/whimsy/asf/mlist.rb
+++ b/lib/whimsy/asf/mlist.rb
@@ -49,10 +49,8 @@ module ASF
       response[:subtime] = (File.mtime(LIST_TIME) rescue File.mtime(LIST_SUBS))
 
       list_parse('sub') do |dom, list, subs|
-        # outside the loop
-        _subs = subs.map{|s| ASF::Mail.to_canonical(s.downcase)}
         emails.each do |email|
-          if _subs.include? ASF::Mail.to_canonical(email.downcase)
+          if downcase(subs).include? email.downcase
             response[:subscriptions] << ["#{list}@#{dom}", email]
           end
         end
@@ -73,10 +71,8 @@ module ASF
       response[:digtime] = (File.mtime(LIST_TIME) rescue File.mtime(LIST_DIGS))
 
       list_parse('dig') do |dom, list, subs|
-        # outside the loop
-        _subs = subs.map{|s| ASF::Mail.to_canonical(s.downcase)}
         emails.each do |email|
-          if _subs.include? ASF::Mail.to_canonical(email.downcase)
+          if downcase(subs).include? email.downcase
             response[:digests] << ["#{list}@#{dom}", email]
           end
         end


Mime
View raw message