whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Always return array even if only one entry
Date Fri, 22 Mar 2019 18:32:54 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 2f432fd  Always return array even if only one entry
2f432fd is described below

commit 2f432fd0b9c03cf393a0cc5e5352126a6876771e
Author: Sebb <sebb@apache.org>
AuthorDate: Fri Mar 22 18:32:43 2019 +0000

    Always return array even if only one entry
---
 www/roster/models/committer.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/roster/models/committer.rb b/www/roster/models/committer.rb
index 8bf4ce8..49570a9 100644
--- a/www/roster/models/committer.rb
+++ b/www/roster/models/committer.rb
@@ -56,11 +56,11 @@ class Committer
     end
 
     if person.attrs['asf-sascore']
-      response[:sascore] = person.attrs['asf-sascore'].first
+      response[:sascore] = person.attrs['asf-sascore'].first # should only be one, but is
returned as array
     end
 
     if person.attrs['githubUsername']
-      response[:githubUsername] = person.githubUsername
+      response[:githubUsername] = person.attrs['githubUsername'] # may be more than one
     end
 
     response[:urls] = person.urls unless person.urls.empty?


Mime
View raw message