whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Revert "Hack to allow editting of multiple entries"
Date Fri, 22 Mar 2019 19:55:28 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 296756e  Revert "Hack to allow editting of multiple entries"
296756e is described below

commit 296756eccd4c1a9461485c9697d5d8304c916d9e
Author: Sebb <sebb@apache.org>
AuthorDate: Fri Mar 22 19:54:30 2019 +0000

    Revert "Hack to allow editting of multiple entries"
    
    This reverts commit 8bc575ec106dc69b6f931683e9ba1cd1b2a68fa9.
---
 www/roster/views/actions/github.json.rb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/www/roster/views/actions/github.json.rb b/www/roster/views/actions/github.json.rb
index 17ca4f5..559d962 100644
--- a/www/roster/views/actions/github.json.rb
+++ b/www/roster/views/actions/github.json.rb
@@ -10,11 +10,7 @@ _ldap.update do
   _previous githubUsername: person.attrs['githubUsername']
 
   if @githubuser and not @dryrun
-    # TODO: Hack to deal with single input field on the form
-    # multiple entries are currently displayed with commas when editting
-    names = @githubuser.split(/[, ]+/)
-    Wunderbar.warn(names.inspect)
-    person.modify 'githubUsername', names 
+    person.modify 'githubUsername', @githubuser
   end
 end
 


Mime
View raw message