whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: better display of missing minutes
Date Sun, 02 Jun 2019 02:02:45 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 8e851de  better display of missing minutes
8e851de is described below

commit 8e851de47da55de30e36ca41560b90c559108fc9
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Sat Jun 1 22:02:29 2019 -0400

    better display of missing minutes
---
 www/board/agenda/views/pages/report.js.rb | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/www/board/agenda/views/pages/report.js.rb b/www/board/agenda/views/pages/report.js.rb
index a4672d8..61da0e0 100644
--- a/www/board/agenda/views/pages/report.js.rb
+++ b/www/board/agenda/views/pages/report.js.rb
@@ -45,7 +45,11 @@ class Report < Vue
 
         if minutes
           _pre.comment do
-            _Text raw: minutes, filters: [hotlink]
+            if minutes === :missing
+              _p { _em 'missing' }
+            else
+              _Text raw: minutes, filters: [hotlink]
+            end
           end
         end
       end
@@ -79,13 +83,14 @@ class Report < Vue
       # if draft is available, fetch minutes for display
       date = @@item.text[/board_minutes_(\d+_\d+_\d+)\.txt/, 1]
 
-      if
-        date and @@item.mtime and not defined? @@item.minutes and
-        defined? XMLHttpRequest
-      then
-        Vue.set @@item, 'minutes', ''
-        retrieve "minutes/#{date}?#{@@item.mtime}", :text do |minutes|
-          @@item.minutes = minutes
+      if date and not defined? @@item.minutes and defined? XMLHttpRequest
+        if @@item.mtime
+          Vue.set @@item, 'minutes', ''
+          retrieve "minutes/#{date}?#{@@item.mtime}", :text do |minutes|
+            @@item.minutes = minutes
+          end
+        else
+          @@item.minutes = :missing
         end
       end
     end


Mime
View raw message