whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ru...@apache.org
Subject [whimsy] branch master updated: Provide instructions to shepherds when reports are missing
Date Mon, 17 Jun 2019 14:42:16 GMT
This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new b5af04b  Provide instructions to shepherds when reports are missing
b5af04b is described below

commit b5af04b68ce776d04e049a51f7a899349193beb7
Author: Sam Ruby <rubys@intertwingly.net>
AuthorDate: Mon Jun 17 10:41:54 2019 -0400

    Provide instructions to shepherds when reports are missing
---
 www/board/agenda/public/stylesheets/app.css |  2 +-
 www/board/agenda/views/pages/report.js.rb   | 23 ++++++++++++++++++++---
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/www/board/agenda/public/stylesheets/app.css b/www/board/agenda/public/stylesheets/app.css
index 06793f5..b5026ca 100644
--- a/www/board/agenda/public/stylesheets/app.css
+++ b/www/board/agenda/public/stylesheets/app.css
@@ -182,7 +182,7 @@ label.checkbox span {
 
 .comment {
   margin-top: 0;
-  margin-bottom: 0;
+  margin-bottom: 1em;
   padding-top: 0;
   padding-bottom: 0.1;
   padding-left: 2em;
diff --git a/www/board/agenda/views/pages/report.js.rb b/www/board/agenda/views/pages/report.js.rb
index eeefa36..f5551e9 100644
--- a/www/board/agenda/views/pages/report.js.rb
+++ b/www/board/agenda/views/pages/report.js.rb
@@ -34,9 +34,26 @@ class Report < Vue
 
         if (@@item.missing or @@item.comments) and @@item.mail_list
           _section.reminder do
-            if @@item.missing and not Posted.get(@@item.title).empty?
-              _button.btn.btn_primary 'post report', data_toggle: 'modal',
-                data_target: '#post-report-form'
+            if @@item.missing and 
+              if not Posted.get(@@item.title).empty?
+                _button.btn.btn_primary 'post report', data_toggle: 'modal',
+                  data_target: '#post-report-form'
+              elsif
+                @@item.attach =~ /^[A-Z]/ and
+                User.firstname and @@item.shepherd and
+                User.firstname.start_with? @@item.shepherd.downcase()
+              then
+                _p.comment do
+                  _ 'No report was found on '
+                  _a 'board@apache.org',
+                    href: 'https://lists.apache.org/list.html?board@apache.org'
+                  _ ' archives since the last board report.  If/when a report'
+                  _ ' is posted there with a '
+                  _tt '[Report]'
+                  _ ' tag in the subject line a POST button will appear here '
+                  _ ' to assist with the posting the report.'
+                end
+              end
             end
 
             _Email item: @@item


Mime
View raw message