ws-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cohei...@apache.org
Subject svn commit: r1040626 - in /webservices/wss4j/trunk: src/org/apache/ws/security/components/crypto/ src/org/apache/ws/security/message/token/ src/org/apache/ws/security/processor/ src/org/apache/ws/security/util/ test/wssec/
Date Tue, 30 Nov 2010 16:37:29 GMT
Author: coheigea
Date: Tue Nov 30 16:37:29 2010
New Revision: 1040626

URL: http://svn.apache.org/viewvc?rev=1040626&view=rev
Log:
Changed some StringBuffers to StringBuilders.

Modified:
    webservices/wss4j/trunk/src/org/apache/ws/security/components/crypto/CryptoBase.java
    webservices/wss4j/trunk/src/org/apache/ws/security/message/token/DOMX509IssuerSerial.java
    webservices/wss4j/trunk/src/org/apache/ws/security/processor/EncryptedKeyProcessor.java
    webservices/wss4j/trunk/src/org/apache/ws/security/util/UUIDGenerator.java
    webservices/wss4j/trunk/test/wssec/TestModifiedRequest.java

Modified: webservices/wss4j/trunk/src/org/apache/ws/security/components/crypto/CryptoBase.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/src/org/apache/ws/security/components/crypto/CryptoBase.java?rev=1040626&r1=1040625&r2=1040626&view=diff
==============================================================================
--- webservices/wss4j/trunk/src/org/apache/ws/security/components/crypto/CryptoBase.java (original)
+++ webservices/wss4j/trunk/src/org/apache/ws/security/components/crypto/CryptoBase.java Tue
Nov 30 16:37:29 2010
@@ -242,7 +242,7 @@ public abstract class CryptoBase impleme
     
     protected static String createKeyStoreErrorMessage(KeyStore keystore) throws KeyStoreException
{
         Enumeration<String> aliases = keystore.aliases();
-        StringBuffer sb = new StringBuffer(keystore.size() * 7);
+        StringBuilder sb = new StringBuilder(keystore.size() * 7);
         boolean firstAlias = true;
         while (aliases.hasMoreElements()) {
             if (!firstAlias) {

Modified: webservices/wss4j/trunk/src/org/apache/ws/security/message/token/DOMX509IssuerSerial.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/src/org/apache/ws/security/message/token/DOMX509IssuerSerial.java?rev=1040626&r1=1040625&r2=1040626&view=diff
==============================================================================
--- webservices/wss4j/trunk/src/org/apache/ws/security/message/token/DOMX509IssuerSerial.java
(original)
+++ webservices/wss4j/trunk/src/org/apache/ws/security/message/token/DOMX509IssuerSerial.java
Tue Nov 30 16:37:29 2010
@@ -129,7 +129,7 @@ public final class DOMX509IssuerSerial {
     
     private String getChildText(Node parentNode) {
         Node node = parentNode.getFirstChild();
-        StringBuffer buffer = new StringBuffer();
+        StringBuilder buffer = new StringBuilder();
         while (node != null) {
             if (Node.TEXT_NODE == node.getNodeType()) {
                 buffer.append(((Text)node).getData());

Modified: webservices/wss4j/trunk/src/org/apache/ws/security/processor/EncryptedKeyProcessor.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/src/org/apache/ws/security/processor/EncryptedKeyProcessor.java?rev=1040626&r1=1040625&r2=1040626&view=diff
==============================================================================
--- webservices/wss4j/trunk/src/org/apache/ws/security/processor/EncryptedKeyProcessor.java
(original)
+++ webservices/wss4j/trunk/src/org/apache/ws/security/processor/EncryptedKeyProcessor.java
Tue Nov 30 16:37:29 2010
@@ -235,7 +235,7 @@ public class EncryptedKeyProcessor imple
      * @throws WSSecurityException
      */
     public static byte[] getDecodedBase64EncodedData(Element element) throws WSSecurityException
{
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         Node node = element.getFirstChild();
         while (node != null) {
             if (Node.TEXT_NODE == node.getNodeType()) {

Modified: webservices/wss4j/trunk/src/org/apache/ws/security/util/UUIDGenerator.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/src/org/apache/ws/security/util/UUIDGenerator.java?rev=1040626&r1=1040625&r2=1040626&view=diff
==============================================================================
--- webservices/wss4j/trunk/src/org/apache/ws/security/util/UUIDGenerator.java (original)
+++ webservices/wss4j/trunk/src/org/apache/ws/security/util/UUIDGenerator.java Tue Nov 30
16:37:29 2010
@@ -73,7 +73,7 @@ public class UUIDGenerator {
         } catch (UnknownHostException e) {
             sid = Thread.currentThread().getName();
         }
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append(sid);
         sb.append(":");
         sb.append(Long.toString(rand));
@@ -88,7 +88,7 @@ public class UUIDGenerator {
         }
         md5.update(sb.toString().getBytes());
         byte[] array = md5.digest();
-        StringBuffer sb2 = new StringBuffer();
+        StringBuilder sb2 = new StringBuilder();
         for (int j = 0; j < array.length; ++j) {
             int b = array[j] & 0xFF;
             sb2.append(Integer.toHexString(b));

Modified: webservices/wss4j/trunk/test/wssec/TestModifiedRequest.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/test/wssec/TestModifiedRequest.java?rev=1040626&r1=1040625&r2=1040626&view=diff
==============================================================================
--- webservices/wss4j/trunk/test/wssec/TestModifiedRequest.java (original)
+++ webservices/wss4j/trunk/test/wssec/TestModifiedRequest.java Tue Nov 30 16:37:29 2010
@@ -142,7 +142,6 @@ public class TestModifiedRequest extends
      * so that the signed "value" element is put in the header, and the value of the
      * original element is changed. The wsu:Id value of the original element is also
      * changed. Signature verification will pass, so we need to check that wsu:Id's.
-     * TODO - failing after JSR105 move
      */
     public void testMovedElementChangedId() throws Exception {
         WSSecSignature builder = new WSSecSignature();



Mime
View raw message