ws-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From veit...@apache.org
Subject svn commit: r1697265 - in /webservices/axiom/trunk/implementations: axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultImpl.java axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultImpl.java
Date Sun, 23 Aug 2015 21:47:03 GMT
Author: veithen
Date: Sun Aug 23 21:47:03 2015
New Revision: 1697265

URL: http://svn.apache.org/r1697265
Log:
No need to store the exception. It is never used later.

Modified:
    webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultImpl.java
    webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultImpl.java

Modified: webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultImpl.java?rev=1697265&r1=1697264&r2=1697265&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultImpl.java
(original)
+++ webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/soap/impl/dom/SOAPFaultImpl.java
Sun Aug 23 21:47:03 2015
@@ -19,7 +19,6 @@
 
 package org.apache.axiom.soap.impl.dom;
 
-import org.apache.axiom.om.OMCloneOptions;
 import org.apache.axiom.om.OMConstants;
 import org.apache.axiom.om.OMElement;
 import org.apache.axiom.om.OMException;
@@ -40,14 +39,11 @@ import java.io.StringWriter;
 public abstract class SOAPFaultImpl extends SOAPElement implements AxiomSOAPFault,
         OMConstants {
 
-    protected Exception e;
-
     public SOAPFaultImpl(OMFactory factory) {
         super(factory);
     }
 
     public void setException(Exception e) {
-        this.e = e;
         putExceptionToSOAPFault(e);
     }
 
@@ -86,11 +82,4 @@ public abstract class SOAPFaultImpl exte
                                                     null, null, getOMFactory(), true);
         faultDetailEnty.setText(sw.getBuffer().toString());
     }
-
-    @Override
-    protected final void copyData(OMCloneOptions options, NSAwareElement clone) {
-        if (e != null) {
-            ((SOAPFault)clone).setException(e);
-        }
-    }
 }

Modified: webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultImpl.java?rev=1697265&r1=1697264&r2=1697265&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultImpl.java
(original)
+++ webservices/axiom/trunk/implementations/axiom-impl/src/main/java/org/apache/axiom/soap/impl/llom/SOAPFaultImpl.java
Sun Aug 23 21:47:03 2015
@@ -43,14 +43,11 @@ import java.io.StringWriter;
 public abstract class SOAPFaultImpl extends SOAPElement
         implements AxiomSOAPFault, OMConstants {
 
-    protected Exception e;
-
     public SOAPFaultImpl(OMFactory factory) {
         super(factory);
     }
 
     public void setException(Exception e) {
-        this.e = e;
         putExceptionToSOAPFault(e);
     }
 
@@ -91,8 +88,6 @@ public abstract class SOAPFaultImpl exte
     }
 
     protected OMElement createClone(OMCloneOptions options, OMContainer targetParent) {
-        return e == null ?
-                ((SOAPFactory)getOMFactory()).createSOAPFault((SOAPBody) targetParent):
-                ((SOAPFactory)getOMFactory()).createSOAPFault((SOAPBody) targetParent, e);
+        return ((SOAPFactory)getOMFactory()).createSOAPFault((SOAPBody) targetParent);
     }
 }



Mime
View raw message