ws-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From veit...@apache.org
Subject svn commit: r1797842 - in /webservices/axiom/trunk: aspects/dom-aspects/src/main/java/org/apache/axiom/dom/impl/mixin/ implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ implementations/axiom-dom/src/test/java/org/apache/axiom/om/imp...
Date Tue, 06 Jun 2017 22:57:12 GMT
Author: veithen
Date: Tue Jun  6 22:57:12 2017
New Revision: 1797842

URL: http://svn.apache.org/viewvc?rev=1797842&view=rev
Log:
Fix some test cases.

Modified:
    webservices/axiom/trunk/aspects/dom-aspects/src/main/java/org/apache/axiom/dom/impl/mixin/DOMNodeFactorySupport.aj
    webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/DocumentImpl.java
    webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java

Modified: webservices/axiom/trunk/aspects/dom-aspects/src/main/java/org/apache/axiom/dom/impl/mixin/DOMNodeFactorySupport.aj
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/aspects/dom-aspects/src/main/java/org/apache/axiom/dom/impl/mixin/DOMNodeFactorySupport.aj?rev=1797842&r1=1797841&r2=1797842&view=diff
==============================================================================
--- webservices/axiom/trunk/aspects/dom-aspects/src/main/java/org/apache/axiom/dom/impl/mixin/DOMNodeFactorySupport.aj
(original)
+++ webservices/axiom/trunk/aspects/dom-aspects/src/main/java/org/apache/axiom/dom/impl/mixin/DOMNodeFactorySupport.aj
Tue Jun  6 22:57:12 2017
@@ -19,6 +19,7 @@
 package org.apache.axiom.dom.impl.mixin;
 
 import org.apache.axiom.dom.DOMDocument;
+import org.apache.axiom.dom.DOMDocumentType;
 import org.apache.axiom.dom.DOMNodeFactory;
 import org.w3c.dom.DOMException;
 import org.w3c.dom.Document;
@@ -45,9 +46,12 @@ public aspect DOMNodeFactorySupport {
     }
 
     public DocumentType DOMNodeFactory.createDocumentType(String qualifiedName,
-                                           String publicId, String systemId) throws DOMException
{
-        // TODO
-        throw new UnsupportedOperationException("TODO");
+                                           String publicId, String systemId) {
+        DOMDocumentType docType = createNode(DOMDocumentType.class);
+        docType.coreSetRootName(qualifiedName);
+        docType.coreSetPublicId(publicId);
+        docType.coreSetSystemId(systemId);
+        return docType;
     }
 
     /*

Modified: webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/DocumentImpl.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/DocumentImpl.java?rev=1797842&r1=1797841&r2=1797842&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/DocumentImpl.java
(original)
+++ webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/DocumentImpl.java
Tue Jun  6 22:57:12 2017
@@ -103,11 +103,11 @@ public class DocumentImpl extends Parent
             }
             case Node.ENTITY_REFERENCE_NODE:
             case Node.ENTITY_NODE:
-            case Node.DOCUMENT_TYPE_NODE:
             case Node.NOTATION_NODE:
                 throw new UnsupportedOperationException("TODO : Implement handling of org.w3c.dom.Node
type == " + type );
 
             case Node.DOCUMENT_NODE: // Can't import document nodes
+            case Node.DOCUMENT_TYPE_NODE:
             default:
                 throw newDOMException(DOMException.NOT_SUPPORTED_ERR);
         }

Modified: webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java?rev=1797842&r1=1797841&r2=1797842&view=diff
==============================================================================
--- webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
(original)
+++ webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
Tue Jun  6 22:57:12 2017
@@ -64,8 +64,6 @@ public class DOMImplementationTest exten
         builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/createDocumentType02)");
         builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/createDocumentType03)");
         builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/createDocumentType04)");
-        builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/documentimportnode07)");
-        builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/documentimportnode08)");
         builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/documentimportnode14)");
         builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/documentimportnode21)");
         builder.exclude(W3CTestCase.class, "(id=http://www.w3.org/2001/DOM-Test-Suite/level2/core/documenttypeinternalSubset01)");



Mime
View raw message