ws-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AXIOM-435) Consistently implement support for entity references
Date Mon, 20 Aug 2012 20:31:38 GMT

    [ https://issues.apache.org/jira/browse/AXIOM-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438172#comment-13438172
] 

Hudson commented on AXIOM-435:
------------------------------

Integrated in ws-axiom-trunk #1173 (See [https://builds.apache.org/job/ws-axiom-trunk/1173/])
    AXIOM-435: Added factory methods to create entity references programmatically. (Revision
1375176)

     Result = SUCCESS
veithen : 
Files : 
* /webservices/commons/trunk/modules/axiom/modules/axiom-api/src/main/java/org/apache/axiom/om/OMFactory.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/factory/OMDOMFactory.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/factory/OMLinkedListImplFactory.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/OMTestSuiteBuilder.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/factory/TestCreateOMEntityReference.java
* /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/factory/TestCreateOMEntityReferenceWithNullParent.java

                
> Consistently implement support for entity references
> ----------------------------------------------------
>
>                 Key: AXIOM-435
>                 URL: https://issues.apache.org/jira/browse/AXIOM-435
>             Project: Axiom
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 1.2.13
>            Reporter: Andreas Veithen
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.2.14
>
>
> Currently (unexpanded) entity references are represented as OMText instances with type=ENTITY_REFERENCE_NODE.
This is a bad choice:
> * An entity reference doesn't necessarily represent character data: the expansion can
e.g. produce elements. Representing it as an OMText is therefore conceptually wrong.
> * There is lots of code that checks for OMText and then uses OMText#getText() under the
assumption that the return value represents character data. However, for an entity reference,
getText() would return the entity name.
> It should also be noted that the test coverage for entity references is currently almost
nonexistent. As a result, the code that handles entity references is inconsistent. E.g. OMStAXWrapper/SwitchingWrapper
contains the following code:
>             if ((currentEvent == START_ELEMENT)
>                     || (currentEvent == END_ELEMENT)
>                     || (currentEvent == ENTITY_REFERENCE)) {
>                 return ((OMElement) lastNode).getLocalName();
>             } else {
>                 throw new IllegalStateException();
>             }
> This is obviously incorrect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


Mime
View raw message