ws-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marc Giger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WSS-355) Reconcile SAMLCallback between the two implementations
Date Thu, 08 Nov 2012 10:35:14 GMT

    [ https://issues.apache.org/jira/browse/WSS-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493094#comment-13493094
] 

Marc Giger commented on WSS-355:
--------------------------------

Hi Colm,

The StAX and DOM productive code uses the same SAMLCallback:
./ws-security-common/src/main/java/org/apache/ws/security/common/saml/SAMLCallback.java

For testing we have the following Callback's:
./ws-security-stax/src/test/java/org/apache/ws/security/stax/test/saml/AbstractSAMLCallbackHandler.java
./ws-security-stax/src/test/java/org/apache/ws/security/stax/test/saml/SAML2CallbackHandler.java
./ws-security-stax/src/test/java/org/apache/ws/security/stax/test/saml/SAML1CallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/AbstractSAMLCallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/SAML2CallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/SAMLElementCallbackHandler.java
./ws-security-dom/src/test/java/org/apache/ws/security/dom/common/SAML1CallbackHandler.java

The differences between these are the issuer things which is necessary because of the different
testing setup for StAX.
I can refactor it so that both test implementations use the same Callbacks but the issuer
stuff will still be needed for StAX testing.

Can/should I refactor it and enrich the common callbacks with the issuer stuff for testing
the StAX impl.?

Marc
                
> Reconcile SAMLCallback between the two implementations
> ------------------------------------------------------
>
>                 Key: WSS-355
>                 URL: https://issues.apache.org/jira/browse/WSS-355
>             Project: WSS4J
>          Issue Type: Sub-task
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 2.0
>
>
> The SAMLCallback in SWSSF contains signing information, whereas it does not in WSS4J.
SAMLParms and SAMLIssuer* will be removed in the DOM code as part of this work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


Mime
View raw message