ws-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Athman (JIRA)" <>
Subject [jira] [Created] (WSS-642) Use LinkedHashSet instead of TreeSet within getInclusivePrefixes
Date Fri, 25 Jan 2019 20:25:00 GMT
Joseph Athman created WSS-642:

             Summary: Use LinkedHashSet instead of TreeSet within getInclusivePrefixes
                 Key: WSS-642
             Project: WSS4J
          Issue Type: Improvement
          Components: WSS4J Core
    Affects Versions: 2.2.2
            Reporter: Joseph Athman
            Assignee: Colm O hEigeartaigh

WSS-626 changed the implementation of the SignatureUtils#getInclusivePrefixes method to use
a Set instead of a List. This change makes sense, however it changes the order that the prefixes
had historically been returned by this method. A client of ours is having a problem with the
new ordering. Although this is certainly a bug on their end, it seems reasonable to replicate
the previous behavior of this method as closely as possible while still fixing the bug reported
in the issue.

I'd like to suggest using a LinkedHashSet instead of a TreeSet as the Set implementation in
this method. The LHS preserves the insertion order as the order the elements are returned
in. This should make this method behave as closely as possible prior to the 2.2.2 release
of WSS4J.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message