ws-savan-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Veithen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AXIS2-4640) WSDL2Java Generated Non-sensible Code
Date Mon, 01 Mar 2010 22:24:05 GMT

     [ https://issues.apache.org/jira/browse/AXIS2-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andreas Veithen updated AXIS2-4640:
-----------------------------------

    Priority: Minor  (was: Major)

This is not a bug. This code is generated for nillable elements. The rationale is that when
setting a property for a nillable element to null, the property is still set and an element
must be generated. For non nillable elements the generated code is different. Obviously the
generated code is suboptimal (in both cases actually, since for non nillable elements the
code could be simplified to localBarcodeTracker = param != null). However, it looks like that
part of the code generator is not covered by unit tests. Before changing the generator, such
unit tests should be added.

> WSDL2Java Generated Non-sensible Code
> -------------------------------------
>
>                 Key: AXIS2-4640
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4640
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5.1
>         Environment: OpenSuse 11.2, JDk 1.6.0
>            Reporter: Vy Ho
>            Assignee: Andreas Veithen
>            Priority: Minor
>
> Java classes that are generated from Web service Parameters (types) have non-sensible
code block (please excuse me for using the term).
> These happens setter methods:
> Take the following example generated code:
>     public void setBarcode(java.lang.String param) {
>         if (param != null) {
>             //update the setting tracker
>             localBarcodeTracker = true;
>         } else {
>             localBarcodeTracker = true;
>         }
>         this.localBarcode = param;
>     }
> localBarcodeTracker is always set to true in either case.  This either is a bug, or it's
redundant check.  This happens to every other property setters that I have seen so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message