www-modproxy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bar...@veribox.net
Subject [PATCH] fix proxy_http.c
Date Fri, 03 Aug 2001 07:52:57 GMT
appending flush bucket to the brigade is redundant since the EOS

bucket indicates that there will be no more data and the filter
should flush. otherwise, brigade processing gets screwed up and
we sometimes segfault in the core output filter.

Index: proxy_http.c
===================================================================
RCS file: /home/cvspublic/httpd-proxy/module-2.0/proxy_http.c,v
retrieving revision 1.82
diff -u -r1.82 proxy_http.c
--- proxy_http.c        2001/07/31 19:12:56     1.82
+++ proxy_http.c        2001/08/03 05:47:12
@@ -783,8 +783,6 @@
        /* read the body, pass it to the output filters */
        while (ap_get_brigade(rp->input_filters, bb, AP_MODE_BLOCKING,
&readbytes) == APR_SUCCESS) {
            if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(bb))) {
-               e = apr_bucket_flush_create();
-               APR_BRIGADE_INSERT_TAIL(bb, e);
                ap_pass_brigade(r->output_filters, bb);
                break;
            }

john.

Mime
View raw message