xml-rpc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 12552] - [PATCH] Refactored HTTP request out of XmlRpcClient.execute
Date Fri, 27 Sep 2002 21:01:47 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12552>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12552

[PATCH] Refactored HTTP request out of XmlRpcClient.execute





------- Additional Comments From rhoegg@isisnetworks.net  2002-09-27 21:01 -------
Sure.

This patch is a small step preparing for my HttpClient integration project.

When I prepare for a larger code change, I first refactor
(http://www.refactoring.com) the code I will be changing so that the changes
will be simple and straightforward.  As the HTTP request is conceptually
separate from the XML request (2 layers) I refactored the HTTP request from the
execute() method.  This incidentally follows the Extract Method
(http://c2.com/cgi/wiki?ExtractMethod) refactoring.

This change allows one to modify the way the library executes an HTTP request
cleanly.  If we later decide to change the method access to protected, it also
would provide the capability for a subclass to override just the HTTP execution
portion of the code.

Mime
View raw message