xml-rpc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Wilson" <...@wilson.co.uk>
Subject Re: REPOST: https
Date Mon, 11 Nov 2002 10:24:40 GMT

----- Original Message -----
From: "Mauro Canal" <developer@canalsystems.net>
To: <rpc-user@xml.apache.org>
Sent: Monday, November 11, 2002 9:47 AM
Subject: REPOST: https

> Hi
> I recently implemented an easy to use start up functionality (including
> for the Apache XML-RPC package.
> Configuration of the build in servers (WebServer and SecureWebServer) and
> assosciated handlers is done in a XML file (conf/server.xml).
> I put all together on http://canalsystems.net/xml-rpc/index.html


    I have taken a very quick look at the source. In StartupHelper on line
720 you have:

        public void characters(char[] buf, int start, int length) throws
SAXParseException {
            String s = new String(buf, start, length).trim();

A SAX parser is allowed to make multiple calls to characters (e.g. it could
make one call per character). So the trim() call will produce a result which
can differ between parsers. It's better to accumulate the characters in the
StringBuffer and call trim in the end element callback.

>From a XML-RPC project point of view this code adds dependencies to Log4J
and JDK 1.2 or better. We have discussed moving from JDK 1.1 on this list
before in when we looked at moving from Hashtable to HashMap and there was
strong objection from some of the user community (applet and J2ME users).

Logging is an interesting issue - I think we should chew it over on rpc-dev
before adopting a standard solution.

I have cross posted this reply to rpc-dev as the JDK 1.2 and Log4J
discussion is probably better conducted there.

John Wilson
The Wilson Partnership

View raw message