xml-rpc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Hoegg <rho...@isisnetworks.net>
Subject Re: [Fwd: Re: Moving Base64 in HttpClient to commons-codec]
Date Mon, 03 Feb 2003 20:37:58 GMT
I've seen these fly by as you have been updating the Bug.  I imagine 
most of these are Good Things, but I think the Codec people will have 
concerns about silently ignoring things the RFC encourages us to 
complain about.  You think we should raise some sort of exception?

Ryan Hoegg
ISIS Networks

Martin Redington wrote:

> np, but you might want to check out my most recent patches on bug 9931.
> These added:
> a final newline to encoded data (which seems to be RFC compliant, as 
> lines are supposed to be folded as "at most" 76 characters, and this 
> is also how the Perl base64 behaves).
> discarding of whitespace and any non-base64 chars in decode() [which 
> is RFC compliant, although the RFC encourages an exception or warning 
> if non-base64 chars are detected].
> significant speedups (about 50%) to decode(). The Vectors slowed the 
> old version down quite a bit.
> There was also a patch to Base64Test that fixed a few minor issues 
> (and is necessary for the "final newline" change above to pass the 
> tests).
> If you have any q's or problems with the patches let me know ...
>     cheers,
>             m.

View raw message