xmlgraphics-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46583] [PATCH] PS tiling patterns implementation
Date Thu, 12 Mar 2009 10:14:58 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46583





--- Comment #9 from Jeremias Maerki <jeremias@apache.org>  2009-03-12 03:14:56 PST ---
Jiri, your ICLA (and the CCLA) has finally been recorded. I've also already
taken the time to process the patch and applied it with modifications:
http://svn.apache.org/viewvc?rev=752822&view=rev

As you can see in the commit message, I found a bug concerning the anchor
rectangle. I found that using the example I've just committed:
http://svn.apache.org/viewvc?rev=752824&view=rev

Another problem which I didn't realize earlier is that your changes violate the
DSC specification. Here's the scenario:
Create a PostScript document with two pages and use the same TexturePaint on
both pages. Then extract the second page according to DSC rules and you get an
invalid PostScript file (because it misses the pattern that is part of the
first page).
The example above demonstrates this. This is not catastrophic but it should be
fixed at some point. This is why I'll leave this issue open for the time being.

I think there are two approaches:
1. limit the reuse of tiling patterns to one page and ignore DSC for pattern
resources.
2. Tie pattern resources into resource tracking. This will require changes in
PSDocumentGraphics2D similar to what we do in Apache FOP: we create the
PostScript file as a temporary file and create common resources in the setup
part in a second pass. See:
http://svn.eu.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/ps/ResourceHandler.java?view=markup

Thanks for your patience, Jiri.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org


Mime
View raw message