airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (AIRAVATA-2163) optimize credential store data models
Date Tue, 13 Dec 2016 17:24:58 GMT


ASF GitHub Bot commented on AIRAVATA-2163:

GitHub user machristie opened a pull request:

    AIRAVATA-2163 Setting type on CredentialSummary

    Setting 'type' since it is required on CredentialSummary.

You can merge this pull request into a Git repository by running:

    $ git pull AIRAVATA-2163-optimize-credential-store-data-models

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
commit 9865e7e2404c8ce4d3554f563b8cb987e8211325
Author: Marcus Christie <>
Date:   2016-12-13T17:21:40Z

    AIRAVATA-2163 Setting type on CredentialSummary


> optimize credential store data models
> -------------------------------------
>                 Key: AIRAVATA-2163
>                 URL:
>             Project: Airavata
>          Issue Type: Improvement
>          Components: Airavata API
>         Environment: Development
>            Reporter: Anuj Bhandar
>            Assignee: Anuj Bhandar
>              Labels: GATask
>             Fix For: 17
> This improvement is based on the following Pull request :
> **Improvements agreed upon :** 
> Followings are few suggestions to improve your pull request.
>     * We can do this in a better way by adding generic API method(to AiravataAPIServer)
like "getAllCredentialSummary" instead of adding API method for each credential types eg:
"getAllGatewaySSHPubKeysSummary" which will return all the credential summary for that particular
gatewayId. You may be able to remove few redundant methods from Airavata API server.
>     * Let's introduced one credential summary struct to all credential types, how we
differentiate is we have credential type enum field( SSH, PASSWD, CERT etc ) in the credential
summary thrift struct.
>      * Move credential data model thrift file to data model directory and merge credential
summary thrift file with it.
>      * Credential stubs still have date fields in generated thrift files, not because
your changes, but we need to fix it so remove it.

This message was sent by Atlassian JIRA

View raw message