airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (AIRAVATA-2163) optimize credential store data models
Date Tue, 13 Dec 2016 19:55:58 GMT


ASF GitHub Bot commented on AIRAVATA-2163:

Github user asfgit closed the pull request at:

> optimize credential store data models
> -------------------------------------
>                 Key: AIRAVATA-2163
>                 URL:
>             Project: Airavata
>          Issue Type: Improvement
>          Components: Airavata API
>         Environment: Development
>            Reporter: Anuj Bhandar
>            Assignee: Anuj Bhandar
>              Labels: GATask
>             Fix For: 17
> This improvement is based on the following Pull request :
> **Improvements agreed upon :** 
> Followings are few suggestions to improve your pull request.
>     * We can do this in a better way by adding generic API method(to AiravataAPIServer)
like "getAllCredentialSummary" instead of adding API method for each credential types eg:
"getAllGatewaySSHPubKeysSummary" which will return all the credential summary for that particular
gatewayId. You may be able to remove few redundant methods from Airavata API server.
>     * Let's introduced one credential summary struct to all credential types, how we
differentiate is we have credential type enum field( SSH, PASSWD, CERT etc ) in the credential
summary thrift struct.
>      * Move credential data model thrift file to data model directory and merge credential
summary thrift file with it.
>      * Credential stubs still have date fields in generated thrift files, not because
your changes, but we need to fix it so remove it.

This message was sent by Atlassian JIRA

View raw message