airavata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AIRAVATA-2282) Notifications are not displaying in reverse creation date order
Date Fri, 30 Dec 2016 20:17:58 GMT

    [ https://issues.apache.org/jira/browse/AIRAVATA-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15788269#comment-15788269
] 

ASF subversion and git services commented on AIRAVATA-2282:
-----------------------------------------------------------

Commit 53b52dcf1dd1049280c6155ae16ddbccb41e04d2 in airavata's branch refs/heads/master from
[~marcuschristie]
[ https://git-wip-us.apache.org/repos/asf?p=airavata.git;h=53b52dc ]

AIRAVATA-2282 notification sort: Prevent int overflow

Instead of returning the difference as a long and casting to an int,
which risks integer overflow, just return 1 or -1 corresponding to the
sign of the difference.


> Notifications are not displaying in reverse creation date order
> ---------------------------------------------------------------
>
>                 Key: AIRAVATA-2282
>                 URL: https://issues.apache.org/jira/browse/AIRAVATA-2282
>             Project: Airavata
>          Issue Type: Bug
>         Environment: dev.seagrid.org, seagrid.org
>            Reporter: Marcus Christie
>            Assignee: Marcus Christie
>             Fix For: 0.17
>
>
> Notices aren't displaying in reverse order by creation date.
> The problem I believe is that creation unix timestamps are subtracted, resulting in a
{{long}}, and this is cast to an {{int}} resulting in overflow if the difference is greater
than the range of numbers that can be represented by ints.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message