allura-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brond...@apache.org
Subject [2/3] allura git commit: [#8077] Fixed naming of author_icon_url to be accurate with what the method does
Date Mon, 23 May 2016 15:14:08 GMT
[#8077] Fixed naming of author_icon_url to be accurate with what the method does


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/672003be
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/672003be
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/672003be

Branch: refs/heads/master
Commit: 672003be3f7feb13f345f08da3a5306baa4262f2
Parents: 665a1a2
Author: Rohan Verma <rohanverma2004@gmail.com>
Authored: Fri May 20 04:09:13 2016 +0530
Committer: Dave Brondsema <dave@brondsema.net>
Committed: Mon May 23 11:04:53 2016 -0400

----------------------------------------------------------------------
 Allura/allura/model/artifact.py | 2 +-
 Allura/allura/model/discuss.py  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/672003be/Allura/allura/model/artifact.py
----------------------------------------------------------------------
diff --git a/Allura/allura/model/artifact.py b/Allura/allura/model/artifact.py
index ba3912a..d750518 100644
--- a/Allura/allura/model/artifact.py
+++ b/Allura/allura/model/artifact.py
@@ -682,7 +682,7 @@ class Message(Artifact):
         from .auth import User
         return User.query.get(_id=self.author_id) or User.anonymous()
 
-    def icon_url(self):
+    def author_icon_url(self):
         from .auth import User
         return User.query.get(_id=self.author_id).icon_url()
 

http://git-wip-us.apache.org/repos/asf/allura/blob/672003be/Allura/allura/model/discuss.py
----------------------------------------------------------------------
diff --git a/Allura/allura/model/discuss.py b/Allura/allura/model/discuss.py
index 65797fe..313c912 100644
--- a/Allura/allura/model/discuss.py
+++ b/Allura/allura/model/discuss.py
@@ -200,7 +200,7 @@ class Thread(Artifact, ActivityObject):
                         text=p.text,
                         subject=p.subject,
                         author=p.author().username,
-                        icon_url=p.icon_url(),
+                        icon_url=p.author_icon_url(),
                         timestamp=p.timestamp,
                         last_edited=p.last_edit_date,
                         attachments=self.attachment_for_export(p) if is_export else self.attachemtns_for_json(p))


Mime
View raw message