ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myroslav Papirkovskyy" <mpapyrkovs...@hortonworks.com>
Subject Re: Review Request 24652: Service config version should always clone and rev up (not simply point to an older version)
Date Thu, 14 Aug 2014 08:15:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24652/#review50564
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Сер. 14, 2014, 11:08 до полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24652/
> -----------------------------------------------------------
> 
> (Updated Сер. 14, 2014, 11:08 до полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-6848
>     https://issues.apache.org/jira/browse/AMBARI-6848
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a user wants to "go back" (revert) to a set of configs for a specific serviceconfigversion,
this should create a new serviceconfigversion.
> For example: v1, v2, v3, v4 and v5 (current)
> If user wants to "go back/revert" to v2 of the configs, they want to create v6 of the
serviceconfigversion which is set to all the props of v2 (i.e. a clone).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceConfigVersionResponse.java
491f112 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java
581ed54 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
698e655 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigApplicationEntity.java
6f2f441 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
2727388 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
eb5d36d 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
bb248ba 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 5fc03b1 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c8897f7 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql eb4d073 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d775eea 
>   ambari-server/src/main/resources/properties.json ff5c11f 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ServiceConfigEntityTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
453c26b 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
63b64e4 
> 
> Diff: https://reviews.apache.org/r/24652/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests for ServiceConfigDAO and ServiceConfigEntity. Tests passed
> 
> Results :
> 
> Tests run: 1927, Failures: 0, Errors: 0, Skipped: 14
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message