ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 28808: Upgrade Execute - Add pre-restart and post-restart hooks to perform hdp-select with version
Date Mon, 08 Dec 2014 22:04:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28808/
-----------------------------------------------------------

(Updated Dec. 8, 2014, 10:04 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower.


Changes
-------

Addressed Nate's comments.


Bugs: AMBARI-8593
    https://issues.apache.org/jira/browse/AMBARI-8593


Repository: ambari


Description
-------

Services will need a pre-restart and post-restart hook that can perform the following actions.
Pre-restart, needs to call hdp-select with the version number. It should only be called during
a RESTART command that is performed during a Rolling Upgrade.
Post-restart, needs to perform several checks, like ZK quorum is established and namenode
is live.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/shell.py d832781 
  ambari-common/src/main/python/resource_management/libraries/functions/decorator.py PRE-CREATION

  ambari-common/src/main/python/resource_management/libraries/functions/version.py 9477842

  ambari-common/src/main/python/resource_management/libraries/script/script.py 39511bc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
7e07453 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py
c1a66fb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py
5cc00fc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py
b786204 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py
9b9112c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_service.py
724e101 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 752f504 

Diff: https://reviews.apache.org/r/28808/diff/


Testing
-------

Deployed a new cluster and updated the jar and python scripts. Then perform an upgrade using
the upgrade-2.2.xml pack
-----------------------------------------------------------------------
Ran 246 tests in 3.359s

OK
----------------------------------------------------------------------
Total run:674
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message