ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29378: Implement all pre-upgrade checks
Date Tue, 23 Dec 2014 22:19:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29378/#review65972
-----------------------------------------------------------


The checks are good. In general, the messages should be more descriptive. For a future checkin,
the PreUpgradeCheck can ensure that each host has at least 2.5 GBs of free space.


ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java
<https://reviews.apache.org/r/29378/#comment109272>

    Why is repositoryVersionName not a requirement in the constructor?



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
<https://reviews.apache.org/r/29378/#comment109274>

    "No service can be in maintenance mode" may seem clearer



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
<https://reviews.apache.org/r/29378/#comment109275>

    May be useful to provide the count, or even the first x hosts to make it easier for the
user.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
<https://reviews.apache.org/r/29378/#comment109276>

    Would be useful to list the services and/or hosts.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
<https://reviews.apache.org/r/29378/#comment109277>

    Would be useful to list the hosts and/or count.



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
<https://reviews.apache.org/r/29378/#comment109278>

    In addition to checking existence, the property should be "true"



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
<https://reviews.apache.org/r/29378/#comment109280>

    Would be useful to list the services.


- Alejandro Fernandez


On Dec. 23, 2014, 8:41 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29378/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 8:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-8898
>     https://issues.apache.org/jira/browse/AMBARI-8898
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The following checks should be implemented:
> *All* cluster hosts must satisfy the following:
> 1) It is either in Host Maintenance Mode or heartbeating with the server
> 2) If in Host Maintenance Mode, there are no masters on the host
> 3) If not in Host Maintenance Mode, it must have new version installed
> *All* of the following must be satisfied:
> 1) NameNode HA is enabled
> 2) Make sure work-preserving RM/NM restart is enabled in YARN configuration files
> 3) MR Jobs need to reference the Hadoop libraries from the distributed cache instead
of the cluster
> 4) Tez jobs need to reference the Hadoop libraries from the distributed cache instead
of the cluster
> 5) Oozie jobs need to reference the Hadoop libraries from the distributed cache instead
of the cluster
> 6) All services must be up, not in Service Maintenance Mode, and operational (all components
are up and service check should pass*).
> 7) All DataNode decommissioning must be completed (no DataNode in “decommissioning”
state)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/PreUpgradeCheckRequest.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
0cb20c1 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java 1afc850

>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeCheckHelper.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeChecks.java 83cd632

>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeCheck.java
0d85a93 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeCheckHelperTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29378/diff/
> 
> 
> Testing
> -------
> 
> Tests are passing
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message