ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 29820: Errors in Oracle DB DDL
Date Mon, 12 Jan 2015 21:34:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29820/#review67706
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Jan. 12, 2015, 7:55 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29820/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 7:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9095
>     https://issues.apache.org/jira/browse/AMBARI-9095
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are multiple errors in Oracle DDL:
> 1) BIGINT values;
> 2) Incorrect column definitions;
> 3) insert NULL into ambari.repository_version.upgrade_package
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
7ac9d95 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
58817a8 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
4efb794 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4b915aa 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
76ba75b 
>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29820/diff/
> 
> 
> Testing
> -------
> 
> unit tests in progress
> 
> tested manually on oracle DB, cluster was installed successfully
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message