ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 32326: Enable unit tests to run on Mac
Date Fri, 20 Mar 2015 23:57:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32326/
-----------------------------------------------------------

(Updated March 20, 2015, 11:57 p.m.)


Review request for Ambari and Jonathan Hurley.


Changes
-------

Incorporated comments.


Bugs: AMBARI-10166
    https://issues.apache.org/jira/browse/AMBARI-10166


Repository: ambari


Description
-------

Enable unit tests to run on Mac


Diffs (updated)
-----

  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 6c14e33 
  ambari-agent/src/test/python/ambari_agent/TestController.py e2fd7a7 
  ambari-agent/src/test/python/unitTests.py 0fd6b49 
  ambari-common/src/main/python/ambari_commons/os_check.py 4e93feb 

Diff: https://reviews.apache.org/r/32326/diff/


Testing
-------

Ran the agent unit tests and ensured that new tests got enabled. I will progressively enable
other tests verifying that they do not start failing on mac.

The failed test was failing earlier for me as well.

======================================================================
FAIL: test_dump_command_to_json (TestCustomServiceOrchestrator.TestCustomServiceOrchestrator)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py",
line 1199, in patched
    return func(*args, **keywargs)
  File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py",
line 126, in test_dump_command_to_json
    self.assertEqual(oct(os.stat(json_file).st_mode & 0777), '0600')
AssertionError: '0644' != '0600'

----------------------------------------------------------------------
Ran 307 tests in 19.563s

FAILED (failures=1)


Thanks,

Sumit Mohanty


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message