ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 32503: Add an agent config to discover server hostname via a script
Date Thu, 26 Mar 2015 00:38:09 GMT


> On March 25, 2015, 11:46 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/hostname.py, line 100
> > <https://reviews.apache.org/r/32503/diff/1/?file=906092#file906092line100>
> >
> >     May want to check that out is not None first.

The check later will cover this scenario - modified the log to report None as ''


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32503/#review77826
-----------------------------------------------------------


On March 25, 2015, 11:10 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32503/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 11:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Chuan Liu, and Sid Wagle.
> 
> 
> Bugs: AMBARI-7767
>     https://issues.apache.org/jira/browse/AMBARI-7767
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add an agent config to discover server hostname via a script
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 05af243 
>   ambari-agent/src/main/python/ambari_agent/Controller.py bb85337 
>   ambari-agent/src/main/python/ambari_agent/hostname.py 437eb84 
>   ambari-agent/src/main/python/ambari_agent/main.py fe95e1a 
>   ambari-agent/src/main/python/ambari_agent/security.py 46eddca 
>   ambari-agent/src/test/python/ambari_agent/TestHostname.py 87c69b8 
> 
> Diff: https://reviews.apache.org/r/32503/diff/
> 
> 
> Testing
> -------
> 
> Ran all agent tests and manually tested on a VM.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message