ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 34025: API does not work for same service component metric with multiple function is requested
Date Mon, 11 May 2015 17:30:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34025/#review83236
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On May 11, 2015, 4:48 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34025/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, Myroslav Papirkovskyy,
and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11041
>     https://issues.apache.org/jira/browse/AMBARI-11041
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 2 HBase Graphs (Read Latency and Write Latency) on UI are impacted due to this.
> 
> Fix is to support aggregate functions as first class citizens in the in-memory metrics
map by updating it when creating PropertyProviders with metrics info containing aggregate
functions names.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java
569bb17 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java
7fa9c5e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java
3e32326 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
c05e112 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
3fe0131 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProviderTest.java
befd062 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
b72dcaf 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/metrics.json 2a46f29

> 
> Diff: https://reviews.apache.org/r/34025/diff/
> 
> 
> Testing
> -------
> 
> Manually verified, unit test passes.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message