ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 34542: AMBARI-11299
Date Thu, 21 May 2015 22:52:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34542/#review84812
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
<https://reviews.apache.org/r/34542/#comment136201>

    simpler with just len()



ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
<https://reviews.apache.org/r/34542/#comment136202>

    This is calling .lower() on a property without first checking if it is not None.



ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
<https://reviews.apache.org/r/34542/#comment136203>

    Should check for not None before calling .lower()


- Alejandro Fernandez


On May 21, 2015, 7:35 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34542/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jonathan Hurley, Mahadev
Konar, Nate Cole, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11299
>     https://issues.apache.org/jira/browse/AMBARI-11299
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari stack changes for Ranger Kafka Plugin
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml
ad7689e 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
1b36f28 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
355bb47 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/setup_ranger_kafka.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/kafka-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-policymgr-ssl.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-security.xml
PRE-CREATION 
>   ambari-web/app/data/HDP2.3/site_properties.js 5a351b5 
> 
> Diff: https://reviews.apache.org/r/34542/diff/
> 
> 
> Testing
> -------
> 
> Tested on a instance having Ranger,HDFS and Kafka.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message