ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 37725: AMBARI-12864 : Allow Ranger & Ranger KMS service to installed using custom service user
Date Mon, 24 Aug 2015 21:02:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37725/#review96207
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line
73)
<https://reviews.apache.org/r/37725/#comment151528>

    What happens if this value is not provided?
    Below in the code, there's a call to Directory, that doesn't check if the property is
not None
    
    All of these should have default values, and the code should be more robust in case properties
are missing.


- Alejandro Fernandez


On Aug. 24, 2015, 6:59 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37725/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 6:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan
Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12864
>     https://issues.apache.org/jira/browse/AMBARI-12864
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow user to specify a custom service user to be used for Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
0d2a6d379a781b876aab25ef055652b6e5ae2f4e 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
c9aa97f6c8072dd40de62ef881691d8260e8102e 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
5f6b8fed53ceaf102e16fc7148589761004b1527 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
75371b81bbfc08431937ce07518078e49fd930fb 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
6f039b2ee70ab308260e9d051b6dcc2f83bb636f 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
a3aa5bbf77eab36895dd0916a4c3a32b7a46fe8c 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
d9bb941743bf718733034c4d7e465e9187a20ed2 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
f3914f37e667cd2af71848841f5cf31618855770 
> 
> Diff: https://reviews.apache.org/r/37725/diff/
> 
> 
> Testing
> -------
> 
> Tested on a local centos6 cluster with a custom user.
> 
> ----------------------------------------------------------------------
> Ran 231 tests in 6.497s
> 
> OK
> ----------------------------------------------------------------------
> Total run:784
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message