ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 39356: Adding Apache HAWQ to common services
Date Thu, 15 Oct 2015 20:44:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39356/#review102817
-----------------------------------------------------------


Looks good overall.


ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-site.xml
(line 71)
<https://reviews.apache.org/r/39356/#comment160587>

    /tmp may not always be writable



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py (line
36)
<https://reviews.apache.org/r/39356/#comment160590>

    Please add some PyDoc to all of these functions.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py (line
55)
<https://reviews.apache.org/r/39356/#comment160591>

    Why is this allowed to ignore failures?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py (line
70)
<https://reviews.apache.org/r/39356/#comment160593>

    spacing here looks odd



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py (line
204)
<https://reviews.apache.org/r/39356/#comment160589>

    PyDoc uses """ instead of '''



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
(line 18)
<https://reviews.apache.org/r/39356/#comment160594>

    Nice, this file is organized.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
(line 41)
<https://reviews.apache.org/r/39356/#comment160595>

    FYI, I believe this is available in RHEL7 but not RHEL6. You can drop this if it's not
an issue.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqmaster.py
(line 26)
<https://reviews.apache.org/r/39356/#comment160596>

    Please add some PyDoc to new classes.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqsegment.py
(line 28)
<https://reviews.apache.org/r/39356/#comment160597>

    Please add some PyDoc to new classes.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstandby.py
(line 26)
<https://reviews.apache.org/r/39356/#comment160598>

    Please add some PyDoc to new classes.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
(line 53)
<https://reviews.apache.org/r/39356/#comment160599>

    If pid is still "", then the call to File will fail.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py (line
52)
<https://reviews.apache.org/r/39356/#comment160600>

    This is getting index 0 without first checking the length



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py (line
68)
<https://reviews.apache.org/r/39356/#comment160601>

    This is getting index 0 without first checking the length



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/service_check.py
(line 32)
<https://reviews.apache.org/r/39356/#comment160602>

    Nice



ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py (line
26)
<https://reviews.apache.org/r/39356/#comment160603>

    Can any of these functions move up to ambari-common so they can be shared?


- Alejandro Fernandez


On Oct. 15, 2015, 8:07 p.m., Newton Alex wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39356/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 8:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, jun aoki, Mahadev Konar, and Oleksandr
Diachenko.
> 
> 
> Bugs: AMBARI-12320
>     https://issues.apache.org/jira/browse/AMBARI-12320
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding Apache HAWQ to common services
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml 17e9ea9 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/gpcheck-env.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/configuration/hawq-site.xml
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/common.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/constants.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqmaster.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqsegment.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstandby.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/hawqstatus.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/master_helper.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/service_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/scripts/utils.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq-hosts.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq-profile.sh.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.limits.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/hawq.sysctl.conf.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0.0/package/templates/slaves.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0.0/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/common-services/PXF/3.0.0.0/package/scripts/pxfservice.py
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39356/diff/
> 
> 
> Testing
> -------
> 
> Adding support for Apache HAWQ (http://hawq.incubator.apache.org/) in Ambari
> 
> 
> Thanks,
> 
> Newton Alex
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message