ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Zang" <rz...@hortonworks.com>
Subject Re: Review Request 40505: Add permission label to to the dataset returned by the privilege resource provider
Date Thu, 19 Nov 2015 22:46:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40505/#review107260
-----------------------------------------------------------

Ship it!


Ship It!

- Richard Zang


On Nov. 19, 2015, 10:43 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40505/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 10:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Richard Zang, Sumit Mohanty, and Sid
Wagle.
> 
> 
> Bugs: AMBARI-13976
>     https://issues.apache.org/jira/browse/AMBARI-13976
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add permission name to to the dataset returned by the privilege resource provider.
> 
> The expected dataset for a privilege item is:
> ```
> {
>   "href" : "http://ambari-server:8080/api/v1/privileges/1",
>   "PrivilegeInfo" : {
>     "permission_name" : "AMBARI.ADMINISTRATOR",
>     "permission_label" : "Administrator",
>     "principal_name" : "admin",
>     "principal_type" : "USER",
>     "privilege_id" : 1,
>     "type" : "AMBARI"
>   }
> }
> ```
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java
f4839e9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java
b2d8018 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java
154229a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
0621286 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java
090805e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
6286aea 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProviderTest.java
62ff60d 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
c156a38 
> 
> Diff: https://reviews.apache.org/r/40505/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> #Local test results: PENDING
> 
> #Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message