ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vivek Ratnavel <vivekratna...@apache.org>
Subject Re: New JIRA - Commit messages
Date Thu, 11 Jan 2018 23:50:07 GMT
Hi Nate,

I find the addition of (username) to commit messages as redundant, since
the user who contributed can be identified from the "Author" tag in git
command line. I use "git log --grep=AMBARI-XXXXX" and get an output with
the author tag. Regardless of the committer who merged the pull request,
the "Author" tag will contain the original contributors name. In your
example, it will be "Author: Joe Smith". The PR might have been merged by
any committer with write access, but it becomes irrelevant.

commit 1eead54f467c7ff6abafa908abf5b66a7278a45a
Author: Olivér Szabó <oleewere@gmail.com>
Date:   Wed Jan 10 21:13:12 2018 +0100

    [AMBARI-22749] ADDENDUM: Create Pull Request Template - fix rat check
(#82)

commit 493612494740ab9b6a7b1e470951baf5cfbee78e
Merge: 30f3a04 1bb2355
Author: Vivek Ratnavel Subramanian <vivekratnavel90@gmail.com>
Date:   Tue Jan 9 13:00:09 2018 -0800

    Merge pull request #70 from vivekratnavel/AMBARI-22749-trunk

    [AMBARI-22749] Create Pull Request Template

-Vivek Ratnavel

On Thu, Jan 11, 2018 at 3:37 PM, Nate Cole <ncole@apache.org> wrote:

> All,
>
>
>
> Previous to the fork/pull request framework, we used to use commit message
> variations like so:
>
>
>
> “AMBARI-XXXXXX. Great change for stack (ncole)”           (for committers)
>
> or
>
> “AMBARI-XXXXXX. Great change for stack (Joe Smith via ncole)”       (for
> contributors)
>
>
>
> Commits have started abandoning this syntax.
>
>
>
> While I agree that the new workflow makes it clear the committer vs the
> author, it was useful to search just commit messages and pair them with the
> author.
>
>
>
> I would propose we keep the “(username)” practice with commit message
>
>
>
> since we don’t always use github for viewing history.  Contributors can
> use something like:
>
>
>
> “(Joe Smith via pull request)” or just “(Joe Smith)”
>
>
>
> Thoughts?
>
> -Nate
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message