ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vivek Ratnavel <>
Subject [DISCUSS] Future code review and commit process
Date Wed, 03 Jan 2018 23:55:53 GMT
Hi all,

As we are linking our github accounts with gitbox to gain write access to
github repository, I wanted to start a discussion on the future code review
and commit process.

After taking a look at other Apache projects including Apache Spark, I
suggest we adapt the following flow:

   - A JIRA is created with all the required details at
   - Create a new branch from local fork and push commits to that branch
   - Run all the tests and update or add new tests if required
   - Open a pull request against trunk or any other branch. I suggest using
   PR title format similar to what Apache Spark is using.

   1. The pull request title should be of the form [AMBARI-xxxx][COMPONENT]
      Title, where AMBARI-xxxx is the relevant JIRA number, COMPONENT is
      one of the ambari components such as ambari-server, ambari-web, etc. and
      Title may be the JIRA’s title or a more specific title describing the
      PR itself.
      2. If the pull request is still a work in progress, and so is not
      ready to be merged, but needs to be pushed to Github to
facilitate review,
      then add [WIP] after the component.

Following such a format to create pull requests will help us create a
portal such as in the future to keep track
of open pull requests. Thanks to github's rich set of APIs.

   - Wait for a +1 or approval of PR from any committer. If there is a need
   for update, keep pushing commits to the same branch and notify the reviewer
   of the update.
   - If a PR has +1 from a committer, any committer can then go ahead and
   merge the PR and mark the JIRA as resolved

Please let me know what you think about this flow. Your feedback is

Vivek Ratnavel

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message